Repository navigation
build: hold requirements at Python 3.11 until the LMS moves to 3.12 - #241
Open
jristau1984 wants to merge 3 commits into
Open
jristau1984 wants to merge 3 commits into
jristau1984 wants to merge 3 commits into
Conversation
The shared upgrade-python-requirements workflow defaults to Python 3.12, so the requirements bot pins versions that need 3.12 (e.g. edx-django-utils 8.2, code-annotations 3.0, sphinx 9.1). CI and edx.org's LMS run Python 3.11, so those pins fail to install and every bot PR goes red. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keeps requirements compiled on 3.11 (what edx.org runs today) while showing whether devstack's tooling is ready for 3.12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nputs The previous commit put python_version under workflow_dispatch.inputs.branch, which made the YAML invalid. Move it into the reusable workflow job's with block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jristau1984
force-pushed
the
jristau/requirements-bot-python-3.11
branch
from
November 21, 2026 04:35
eed14e7 to
f7a8def
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hold the requirements bot at Python 3.11 for compiling pins, while testing on 3.11 and 3.12.
Why
We're moving to Python 3.12, but edx.org's LMS still runs 3.11 (the edx-platform image is on Ubuntu focal with vendored Python 3.11; see BOMS-239). Code installed into the LMS has to stay installable on 3.11 until that changes.
The shared
upgrade-python-requirementsworkflow compiles on 3.12, which pins versions that require Python >=3.12 (for exampleedx-django-utils==8.2.0,code-annotations==3.0.0,sphinx==9.1.1). Those can't install on 3.11, so the bot's PRs fail (see #240).Rule of thumb: compile pins on the oldest supported Python, test on all supported versions.
This PR also adds 3.12 to the quality workflow's matrix (
fail-fast: false), so CI shows whether devstack's tooling is ready for 3.12 without blocking on it.When the LMS moves to 3.12
Switch
python_versionto "3.12" here and drop 3.11 from the test matrix.After merge
Close #240 and run the "Upgrade Requirements" workflow manually for a fresh PR compiled on 3.11.
Generated with Claude Code on behalf of @jristau1984.
🤖 Generated with Claude Code